Open code423n4 opened 2 years ago
cmichel
The Stream.constructor performs a check on a storage variable instead of the parameter: require(feePercent < 10000, "fee"). This will do an unnecessary sload operation. Consider doing the check on _feePercent instead.
Stream.constructor
require(feePercent < 10000, "fee")
sload
_feePercent
Handle
cmichel
Vulnerability details
The
Stream.constructor
performs a check on a storage variable instead of the parameter:require(feePercent < 10000, "fee")
. This will do an unnecessarysload
operation. Consider doing the check on_feePercent
instead.