code-423n4 / 2021-11-streaming-findings

0 stars 0 forks source link

Gas: Flashloan only needs to check pre/post balance for `token` #220

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

cmichel

Vulnerability details

The Stream.claimFees function ensures that neither the depositToken nor the rewardToken balance has decreased. It's enough to check that the token (parameter) has not decreased as the token is the only funds that are transferred out and all other functions of this contract are locked, i.e., there's no way to do a second .transfer out.

0xean commented 2 years ago

dupe of #262