code-423n4 / 2021-11-streaming-findings

0 stars 0 forks source link

check for deposit token and reward token are not same #223

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

hack3r-0m

Vulnerability details

Impact

https://github.com/code-423n4/2021-11-streaming/blob/main/Streaming/src/Locke.sol#L795-L803

createStream does not check if deposit token and reward token are different addresses.

Proof of Concept

Not Required

Tools Used

Manual Review

Recommended Mitigation Steps

add check require(rewardToken != depositToken)

0xean commented 2 years ago

dupe of #215