code-423n4 / 2021-11-streaming-findings

0 stars 0 forks source link

Implementations should inherit their interface #234

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

WatchPug

Vulnerability details

It's a best practice for the contract implementations to inherit their interface definition.

Doing so would improve the contract's clarity, and force the implementation to comply with the defined interface.

Instances include:

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L9-L9

contract Governed {

Governed should inherit IGoverned.