code-423n4 / 2021-11-streaming-findings

0 stars 0 forks source link

Insufficient input validation #243

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-11-streaming/blob/5a87fce1190e0da1cf881919ded3573ca9ec4b08/Streaming/src/Locke.sol#L795-L814

Consider introducing reasonable limits for the startTime. If a user (accidentally) sets startTime to a very late time, say years later, and mistakenly fundStream() without checking if the startTime was set correctly, the funds will not be retrievable until the startTime.