code-423n4 / 2021-11-streaming-findings

0 stars 0 forks source link

Unused declared local variables #5

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

robee

Vulnerability details

Unused local variables are gas consuming, since the initial value assignment costs gas. And are a bad code practice. Removing those variables will decrease the gas cost and improve code quality. This is a full list of all the unused storage variables we found in your code base. The format is , , :

    Auth.sol, isAuthorized, cachedAuthority
    RolesAuthority.sol, setRoleCapability, lastRoles
    RolesAuthority.sol, setUserRole, lastRoles
    DSTestPlus.sol, stopMeasuringGas, checkpointGasLeft2
    DSTestPlus.sol, stopMeasuringGas, label
    CREATE3.sol, deploy, proxyChildBytecode
    SSTORE2.sol, write, creationCode
    Locke.t.sol, test_createStream, maxDepositLockDuration
    HEVMTokenExtension.sol, write_balanceOf, bal
brockelmore commented 2 years ago

All test contracts.

0xean commented 2 years ago

out of scope.