search

code-423n4 / 2021-11-vader-findings

0 stars 0 forks source link

Open TODOs #179

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

defsec

Vulnerability details

Impact

Open TODOs can hint at programming or architectural errors that still need to be fixed.

Proof of Concept

The following contract still have TO-DOs.

https://github.com/code-423n4/2021-11-vader/blob/607d2b9e253d59c782e921bfc2951184d3f65825/contracts/dex/pool/VaderPool.sol#L93
https://github.com/code-423n4/2021-11-vader/blob/607d2b9e253d59c782e921bfc2951184d3f65825/contracts/dex/pool/VaderPool.sol#L85
https://github.com/code-423n4/2021-11-vader/blob/607d2b9e253d59c782e921bfc2951184d3f65825/contracts/dex-v2/pool/VaderPoolV2.sol#L157
https://github.com/code-423n4/2021-11-vader/blob/607d2b9e253d59c782e921bfc2951184d3f65825/contracts/dex-v2/pool/VaderPoolV2.sol#L209

Tools Used

Manual code review.

Recommended Mitigation Steps

Consider to resolve these TODOs and bubble up the errors.

SamSteinGG commented 3 years ago

Duplicate of #102