code-423n4 / 2021-11-vader-findings

0 stars 0 forks source link

Toggle function #227

Closed code423n4 closed 2 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

Due to the asynchronous nature of blockchains, it is not advised to use toggle functions. In your case, you have function toggleQueue in contracts VaderPool and VaderPoolV2. A similar issue was reported in another contest and assigned a severity of low, you can read more details here: https://github.com/code-423n4/2021-06-realitycards-findings/issues/157

Recommended Mitigation Steps

Replace with a function where you can specify the exact value that you want to set.