code-423n4 / 2021-11-vader-findings

0 stars 0 forks source link

block times 13s -> 12s #231

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

function setBondTerms relies on block times to be roughly 13.75s:

 // roughly 36 hours (262 blocks / hour)
 require(_input >= 10000, "vesting < 10000");

However, block times are likely to be reduced to 12s soon: https://twitter.com/TimBeiko/status/1456644168986419200

Recommended Mitigation Steps

Just wanted you to be informed about this. It is up to you to decide if this difference is significant enough to make code changes.

0xstormtrooper commented 3 years ago

vesting term can easily be adjusted by contract owner