search

code-423n4 / 2021-11-vader-findings

0 stars 0 forks source link

safe transfer of tokens #234

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

Some token transfers use SafeERC20 library, some don't, e.g.:

 vader.transferFrom(msg.sender, address(this), _amount); 
 vader.safeTransfer(recipient, amount);

Even though you probably know the implementation of this token and trust it, it would be better to unify transfers across the codebase.

Recommended Mitigation Steps

A safe approach is to use this library everywhere where transfers are happening.

SamSteinGG commented 2 years ago

This is a known implementation and as such the severity should be set to no risk.

alcueca commented 2 years ago

Downgraded to code clarity issue, which is then acknowledged by the sponsor.