search

code-423n4 / 2021-11-vader-findings

0 stars 0 forks source link

Whitepaper and code declares different conversion rates #236

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

The whitepaper states that Vader <-> VETH conversion rate is 10'000:1, however it seems that the code declares a different rate:

 // Vader -> Vether Conversion Rate (1000:1)
 uint256 internal constant _VADER_VETHER_CONVERSION_RATE = 1000;

https://github.com/vetherasset/vaderprotocol-whitepaper/blob/main/Vader%20Protocol%20Whitepaper%20V2.pdf

Recommended Mitigation Steps

Consider updating the whitepaper and the codebase to match each other.