code-423n4 / 2021-11-vader-findings

0 stars 0 forks source link

claimGrant function spec and logic mismatch #264

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

hack3r-0m

Vulnerability details

https://github.com/code-423n4/2021-11-vader/blob/main/contracts/tokens/Vader.sol#L197

claimGrant function does not check for "token must hold sufficient Vader allocation for the grant"

fix comment or function.

SamSteinGG commented 2 years ago

This is indirectly checked by the transfer operation itself.

alcueca commented 2 years ago

Dispute accepted, weird syntax, though: ERC20._transfer(...)