search

code-423n4 / 2021-11-vader-findings

0 stars 0 forks source link

inconsistent use of msg.sender and _msgSender() #267

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

hack3r-0m

Vulnerability details

vader.sol uses msg.sender at some places while _msgSender() at some, it can cause issue while utilizing meta-transactions.

make it consistent

SamSteinGG commented 2 years ago

While this is correct, it is a no risk finding

alcueca commented 2 years ago

Using msg.sender and _msgSender has a different behaviour, and might impact state handling. Severity rating is correct.

SamSteinGG commented 2 years ago

@alcueca Using msg.sender and _msgSender is equivalent given that the _msgSender implementation of Context retrieves the msg.sender.