Closed code423n4 closed 2 years ago
gzeon
Incorrect event emitted on BorrowFee update.
https://github.com/code-423n4/2021-11-yaxis/blob/146febcb61ae7fe20b0920849c4f4bbe111c6ba7/contracts/v3/alchemix/Alchemist.sol#L299
Add around L78 event BorrowFeeUpdated(uint256 fee); Replace L299 emit BorrowFeeUpdated(_borrowFee);
event BorrowFeeUpdated(uint256 fee);
emit BorrowFeeUpdated(_borrowFee);
https://github.com/code-423n4/2021-11-yaxis-findings/issues/7
Xuefeng-Zhu
commented
2 years ago Xuefeng-Zhu
commented
2 years ago
Handle
gzeon
Vulnerability details
Impact
Incorrect event emitted on BorrowFee update.
Proof of Concept
https://github.com/code-423n4/2021-11-yaxis/blob/146febcb61ae7fe20b0920849c4f4bbe111c6ba7/contracts/v3/alchemix/Alchemist.sol#L299
Recommended Mitigation Steps
Add around L78
event BorrowFeeUpdated(uint256 fee);Replace L299emit BorrowFeeUpdated(_borrowFee);