code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

Use short circuiting can save gas #209

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/shared/Access/CallProtection.sol#L8-L12

require(
    msg.sender == LibDiamond.diamondStorage().contractOwner ||
        msg.sender == address(this),
    "NOT_ALLOWED"
);

Can be changed to:

require(
    msg.sender == address(this) ||
        msg.sender == LibDiamond.diamondStorage().contractOwner,
    "NOT_ALLOWED"
);

When msg.sender != address(this), can exit earlier and avoiding more expensive check of msg.sender == LibDiamond.diamondStorage().contractOwner.