search

code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

Remove unnecessary variables can make the code simpler and save some gas #214

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/singleJoinExit/SingleTokenJoin.sol#L51-L57

IERC20 inputToken = IERC20(_joinTokenStruct.inputToken);

inputToken.safeTransferFrom(
    msg.sender,
    address(this),
    _joinTokenStruct.inputAmount
);

inputToken is unnecessary as it's being used only once. Can be changed to:

IERC20(_joinTokenStruct.inputToken).safeTransferFrom(
    msg.sender,
    address(this),
    _joinTokenStruct.inputAmount
);