Open code423n4 opened 2 years ago
WatchPug
Zero-address checks is a best practice for input validation of critical address parameters.
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/factories/PieFactoryContract.sol#L54-L59
function setDiamondImplementation(address _diamondImplementation) external onlyOwner { diamondImplementation = _diamondImplementation; }
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/factories/PieFactoryContract.sol#L36-L39
function setDefaultController(address _controller) external onlyOwner { defaultController = _controller; emit DefaultControllerSet(_controller); }
Handle
WatchPug
Vulnerability details
Zero-address checks is a best practice for input validation of critical address parameters.
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/factories/PieFactoryContract.sol#L54-L59
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/factories/PieFactoryContract.sol#L36-L39