Closed code423n4 closed 2 years ago
JMukesh
transfer() does not check the return , due which transfer may get failed without reverting . some tokens does not revert on failure , they just return false
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/singleJoinExit/SingleNativeTokenExitV2.sol#L104
manual review
use safetransferFrom() from oz libraries
Duplicate of #192
0xleastwood
commented
2 years ago
Handle
JMukesh
Vulnerability details
Impact
transfer() does not check the return , due which transfer may get failed without reverting . some tokens does not revert on failure , they just return false
Proof of Concept
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/singleJoinExit/SingleNativeTokenExitV2.sol#L104
Tools Used
manual review
Recommended Mitigation Steps
use safetransferFrom() from oz libraries