code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

unchecked return value from approve() #233

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

JMukesh

Vulnerability details

Impact

due to lack of check for the return value of approve() , function may silently fail

Proof of Concept

https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/singleJoinExit/SingleNativeTokenExitV2.sol#L55

Tools Used

manual review

Recommended Mitigation Steps

use safeApprove() from oz library

loki-sama commented 2 years ago

duplicate #294