Closed code423n4 closed 2 years ago
gzeon
Constant expressions are left as expressions and will recalculate on read, it is recommended to use immutable instead. Ref: https://github.com/ethereum/solidity/issues/9232#issuecomment-646131646
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/Basket/LibBasketStorage.sol#L7 https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/Call/LibCallStorage.sol#L5 https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/ERC20/LibERC20Storage.sol#L5
Duplicate of #281
Handle
gzeon
Vulnerability details
Constant expressions are left as expressions and will recalculate on read, it is recommended to use immutable instead. Ref: https://github.com/ethereum/solidity/issues/9232#issuecomment-646131646
https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/Basket/LibBasketStorage.sol#L7 https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/Call/LibCallStorage.sol#L5 https://github.com/code-423n4/2021-12-amun/blob/98f6e2ff91f5fcebc0489f5871183566feaec307/contracts/basket/contracts/facets/ERC20/LibERC20Storage.sol#L5