0xleastwood
commented
2 years ago No direct security risk, marking as non-critical
Open code423n4 opened 2 years ago
0xleastwood
commented
2 years ago No direct security risk, marking as non-critical
Handle
hubble
Vulnerability details
Impact
Missing zero address check in setDefaultController function of PieFactoryContract.sol
Proof of Concept
File : PieFactoryContract.sol Line : 36 function setDefaultController(address _controller) external onlyOwner { defaultController = _controller; emit DefaultControllerSet(_controller); }
Tools Used
Manual Review
Recommended Mitigation Steps
Add check for zero address in the function setDefaultController