code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

No minimum fees is defined #243

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

JMukesh

Vulnerability details

Impact

Due no minimum fees for setting these values {EntryFee, ExitFee, AnnualizedFee, EntryFeeBeneficiaryShare, ExitFeeBeneficiaryShare} in BasketFacet.sol , it can be set to zero

Tools Used

manual review

Recommended Mitigation Steps

add minFees for the above variables

0xleastwood commented 2 years ago

Marking as non-critical.