code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

Missing zero address check in setRebalanceManager #255

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

hubble

Vulnerability details

Impact

Missing zero address check in setRebalanceManager function of RebalanceManager.sol, RebalanceManagerV2.sol and RebalanceManagerV3.sol

Proof of Concept

Files : RebalanceManager.sol, RebalanceManagerV2.sol and RebalanceManagerV3.sol Function : setRebalanceManager

function setRebalanceManager(address _rebalanceManager)
    external
    onlyRebalanceManager
{
    rebalanceManager = _rebalanceManager;
    emit RebalanceManagerSet(_rebalanceManager);
}

Tools Used

Manual Review

Recommended Mitigation Steps

Add check for zero address in the function setRebalanceManager on all the three RebalanceManager files.

0xleastwood commented 2 years ago

No direct security risk, marking as non-critical