code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

TODOs #261

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

There are TODOs left in the code:

  uint256 minReturn; //Minimum quantity to buy //todo change to price for safty

While this does not cause any direct issue, it indicates a bad smell and uncertainty and makes it harder to audit. Consider fixing TODOs or removing distracting comments.

0xleastwood commented 2 years ago

Duplicate of #267