code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

Open TODOs #267

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

Dravee

Vulnerability details

Impact

Open TODOs can point to architecture or programming issues that still need to be resolved.

Proof of Concept

The TODOs are here: https://github.com/code-423n4/2021-12-amun/blob/main/contracts/basket/contracts/interfaces/IRebalanceManagerV2.sol#L10 https://github.com/code-423n4/2021-12-amun/blob/main/contracts/basket/contracts/interfaces/IRebalanceManager.sol#L12 https://github.com/code-423n4/2021-12-amun/blob/main/contracts/basket/contracts/interfaces/IRebalanceManager.sol#L18 https://github.com/code-423n4/2021-12-amun/blob/main/contracts/basket/contracts/interfaces/IPangolinRebalanceManager.sol#L13

Tools Used

VS Code

Recommended Mitigation Steps

Consider resolving the TODOs before deploying.

0xleastwood commented 2 years ago

Not an issue, marking as non-critical.