Division by `10 ** 18`

[code423n4]

Handle

Czar102

Vulnerability details

Impact

It is recommended to divide by constant variables instead of a number -- 10 ** 18 should be replaced with HUNDRED_PERCENT in relevant contexts in BasketFacet.

The change would improve code readability and flexibility.

Proof of Concept

• BasketFacet::getExitFeeBeneficiaryShare()
• BasketFacet::getExitFeeBeneficiaryShare()
• BasketFacet::exitPool(...)
• BasketFacet::exitPool(...)
• BasketFacet::calcOutStandingAnnualizedFee()
• BasketFacet::calcTokensForAmount(...)
• BasketFacet::calcTokensForAmountExit(...)