code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

Incorrect revert reason in `CallFacet::addCaller(...)` #273

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

Czar102

Vulnerability details

Impact

Incorrect revert reason in CallFacet::addCaller(...)#37 - there aren't "TOO_MANY_CALLERS", the number has only been reached. A user might think that a contract already has too many callers, which is not true.

Recommended Mitigation Steps

Consider replacing "TOO_MANY_CALLERS" with "CALLER_LIMIT_REACHED".

0xleastwood commented 2 years ago

This is not a security risk. Marking non-critical.