Recalculation of the variables inside the loop

[code423n4]

Handle

pauliax

Vulnerability details

Impact

_amount.add(feeAmount) is re-evaluated again and again inside the loop:

  for (uint256 i; i < bs.tokens.length; i++) {
     ...
      uint256 tokenAmount =
          balance(address(token)).mul(_amount.add(feeAmount)).div(
              totalSupply
          );
     ...
  }

These values do not change so consider extracting outside the loop to reduce gas costs.

[0xleastwood]

Duplicate of #205