The APY of the annualized fee is dependent on the frequency of the execution of the BasketFacet::chargeOutstandingAnnualizedFee(). If it is called more frequently, the compounding is more frequent and the APY is higher. For less used baskets, the APY might be lower, because the compounding will happen at lower rate.
Tools Used
Manual analysis
Recommended Mitigation Steps
Consider calculating the fee as the compounding was continous or with a constant compounding period.
Handle
Czar102
Vulnerability details
Impact
The APY of the annualized fee is dependent on the frequency of the execution of the
BasketFacet::chargeOutstandingAnnualizedFee()
. If it is called more frequently, the compounding is more frequent and the APY is higher. For less used baskets, the APY might be lower, because the compounding will happen at lower rate.Tools Used
Manual analysis
Recommended Mitigation Steps
Consider calculating the fee as the compounding was continous or with a constant compounding period.