code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

_swapsV3 after the _swapsV2 #291

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

contract RebalanceManager function rebalance first performs all the _swapsV2 and then all the _swapsV3. However, I imagine the could be a situation when the manager wants to mix these swaps, some v2, some v3 in between.

Recommended Mitigation Steps

Consider introducing a unified structure for v2 and v3 swaps so these can be mixed together in any order.