code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

Validate diamond implementation is not empty #292

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

setDiamondImplementation should check that the address is not empty (0). function bakePie should check that diamondImplementation is not empty, as it needs to be initialized separately by calling setDiamondImplementation.

Recommended Mitigation Steps

require _diamondImplementation / diamondImplementation != address(0)

0xleastwood commented 2 years ago

I think this should be non-critical