Open code423n4 opened 2 years ago
pauliax
setDiamondImplementation should check that the address is not empty (0). function bakePie should check that diamondImplementation is not empty, as it needs to be initialized separately by calling setDiamondImplementation.
require _diamondImplementation / diamondImplementation != address(0)
I think this should be non-critical
non-critical
Handle
pauliax
Vulnerability details
Impact
setDiamondImplementation should check that the address is not empty (0). function bakePie should check that diamondImplementation is not empty, as it needs to be initialized separately by calling setDiamondImplementation.
Recommended Mitigation Steps
require _diamondImplementation / diamondImplementation != address(0)