search

code-423n4 / 2021-12-defiprotocol-findings

0 stars 0 forks source link

Function can be external #101

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

saian

Vulnerability details

Impact

Function can be external

Proof of Concept

Functions: Factory.sol : setMinLicenseFee, setAuctionDecrement, setAuctionMultiplier, setBondPercentDiv, setOwnerSplit Basket.sol: mint, changeLicenseFee, setNewMaxSupply, publishNewIndex, deleteNewIndex Auction.sol: startAuction, killAuction, bondForRebalance, settleAuction Visibility can be changed to external to save gas

Tools Used

Manual Analysis

Recommended Mitigation Steps

Change the visibility of the functions to external

0xleastwood commented 2 years ago

As of solidity ^0.8.0, this is not a gas optimisation.