code-423n4 / 2021-12-defiprotocol-findings

0 stars 0 forks source link

Gas Optimization: Mark immutable variables #131

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

gzeon

Vulnerability details

Impact

auctionImpl and basketImpl can be marked as immutable

https://github.com/code-423n4/2021-12-defiprotocol/blob/205d3766044171e325df6a8bf2e79b37856eece1/contracts/contracts/Factory.sol#L27 IAuction public override immutable auctionImpl; IBasket public override immutable basketImpl;

0xleastwood commented 2 years ago

Duplicate of #57