search

code-423n4 / 2021-12-defiprotocol-findings

0 stars 0 forks source link

`BasketLicenseProposed` better emit proposal id #134

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

gzeon

Vulnerability details

Impact

Since tokenName is user supplied and can be duplicated, it is better to emit proposal id instead.

https://github.com/code-423n4/2021-12-defiprotocol/blob/205d3766044171e325df6a8bf2e79b37856eece1/contracts/contracts/Factory.sol#L91

        emit BasketLicenseProposed(msg.sender, tokenName);
frank-beard commented 2 years ago

not really an issue but good feedback

0xleastwood commented 2 years ago

I think this is better as a non-critical issue.