code-423n4 / 2021-12-defiprotocol-findings

0 stars 0 forks source link

TODO comments should be resolved #135

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

Jujic

Vulnerability details

Impact

As part of the process of bringing the application to production readiness, dev comments (especially TODOs) should be resolved. In many cases, these comments indicate a missing functionality that should be implemented, or some missing necessary validation checks.

Proof of Concept

https://github.com/code-423n4/2021-12-defiprotocol/blob/205d3766044171e325df6a8bf2e79b37856eece1/contracts/contracts/Basket.sol#L13

Tools Used

https://consensys.net/diligence/audits/2021/07/connext-nxtp-noncustodial-xchain-transfer-protocol/#todo-comments-should-be-resolved

Recommended Mitigation Steps

frank-beard commented 2 years ago

not an actual issue with the contracts

0xleastwood commented 2 years ago

I agree, this has no direct security implications and as such should be made non-critical.