search

code-423n4 / 2021-12-defiprotocol-findings

0 stars 0 forks source link

`settleAuction()` method could be set external instead public #136

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

Jujic

Vulnerability details

Impact

settleAuction() method could be set external instead public to save gas. Detailed description of the impact of this finding.

Proof of Concept

https://github.com/code-423n4/2021-12-defiprotocol/blob/205d3766044171e325df6a8bf2e79b37856eece1/contracts/contracts/Auction.sol#L74

Tools Used

Recommended Mitigation Steps

0xleastwood commented 2 years ago

This does not generate gas savings after Solidity version ^0.8.0