search

code-423n4 / 2021-12-defiprotocol-findings

0 stars 0 forks source link

`maxSupply` can be exceeded #146

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

0x0x0x

Vulnerability details

Lets say there is already as many tokens as maxSupply. A user calls burn with amount = 1. handleFees create more than 1 token. Therefore, maxSupply is exceeded. Furthermore, the same can also happen again, when maxSupply is already exceeded.

frank-beard commented 2 years ago

While this could happen, this shouldn't affect any of the functionality of the basket and can be rectified by the publisher by resetting the maxSupply or more burns. Generally I would consider this a low risk issue.

0xleastwood commented 2 years ago

While I agree that this is an issue, it does not lead to any unexpected behaviour and as such I'd deem this as low risk as its more of a state handling issue.