code-423n4 / 2021-12-defiprotocol-findings

0 stars 0 forks source link

Assignment Of Variable To Default in the constructor #159

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

ye0lde

Vulnerability details

Impact

A variable is being assigned its default value in the constructor which is unnecessary. Removing the assignment will save gas when deploying.

Proof of Concept

https://github.com/code-423n4/2021-12-defiprotocol/blob/205d3766044171e325df6a8bf2e79b37856eece1/contracts/contracts/Factory.sol#L22

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Remove line #22

0xleastwood commented 2 years ago

Duplicate of #45