Open code423n4 opened 2 years ago
rishabh
In pushUnderlying function, there are no checks for tokenAmount being greater than zero. This will lead to the execution of safeTransfer function even when tokenAmount is zero and will cost extra gas for nothing.
L281
Manual Code Review
would consider this a gas optimization rather than an issue
Agree this is a gas optimisation.
Handle
rishabh
Vulnerability details
Impact
In pushUnderlying function, there are no checks for tokenAmount being greater than zero. This will lead to the execution of safeTransfer function even when tokenAmount is zero and will cost extra gas for nothing.
Details
L281
Tools Used
Manual Code Review