issues
search
code-423n4
/
2021-12-mellow-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Consider fees while calculating tvl of univ3
#134
code423n4
closed
2 years ago
4
Migrate from NonFungiblePositionManager to UniV3Pool directly
#133
code423n4
opened
2 years ago
0
Make deposit efficient
#132
code423n4
opened
2 years ago
0
Possible price manipulation while adding liquidity to uniV3
#131
code423n4
closed
2 years ago
2
What you guys mean by this line ? Its redundant imo
#130
code423n4
opened
2 years ago
0
No need of separate indexing (NFT_ID => Vault Address)
#129
code423n4
opened
2 years ago
0
Redundant check for timestamp > 0
#128
code423n4
closed
2 years ago
2
Skip initialization of factory address in vault governance by predicting it before hand
#127
code423n4
opened
2 years ago
0
IsContract Function Usage
#126
code423n4
closed
2 years ago
2
"> 0" is less efficient than "!= 0" for unsigned integers
#125
code423n4
closed
2 years ago
1
Function _chargeFees #L212-L217 (LpIssuer.sol) can be refactored for efficiency and clarity
#124
code423n4
closed
2 years ago
1
Save Gas With The Unchecked Keyword
#123
code423n4
opened
2 years ago
0
Constant variables can be immutable (DefaultAccessControl.sol)
#122
code423n4
opened
2 years ago
2
`YearnVault.sol#pull()` will most certainly fail
#121
code423n4
opened
2 years ago
7
Assigned operations to constant variables
#120
code423n4
closed
2 years ago
1
`AaveVault.sol#_pull()` may return wrong `actualTokenAmounts`
#119
code423n4
opened
2 years ago
0
pre-calculate expressions that do not change
#118
code423n4
opened
2 years ago
0
adminApprove will not work
#117
code423n4
opened
2 years ago
0
register the same vault twice
#116
code423n4
closed
2 years ago
2
The Contract Should Approve(0) first
#115
code423n4
opened
2 years ago
1
Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom
#114
code423n4
closed
2 years ago
1
ERC20 approve method missing return value check
#113
code423n4
closed
2 years ago
2
`ERC20Vault` does not support fee-on-transfer token
#112
code423n4
closed
2 years ago
2
`UniV3Vault` does not distribute fee earning to depositor
#111
code423n4
opened
2 years ago
2
Strategy can steal all the funds in `ERC20Vault` by rebalancing with a fake token in `path`
#110
code423n4
closed
2 years ago
2
Unchecked ERC20 Transfer
#109
code423n4
closed
2 years ago
2
`ChiefTrader.sol` Wrong implementation of `swapExactInput()` and `swapExactOutput()`
#108
code423n4
opened
2 years ago
1
Swap functions in ERC20 Vault will cause fund loss
#107
code423n4
closed
2 years ago
2
These functions can be made modifier
#106
code423n4
opened
2 years ago
2
Guard for initialization function of VaultGovernance
#105
code423n4
opened
2 years ago
0
Use literal `2` instead of read from storage for `_vaultTokens.length` can save gas
#104
code423n4
opened
2 years ago
0
Declaring unnecessary immutable variables as constant can save gas
#103
code423n4
opened
2 years ago
2
Adding unchecked directive can save gas
#102
code423n4
opened
2 years ago
0
Unnecessary checked arithmetic in for loops
#101
code423n4
opened
2 years ago
0
Outdated compiler version
#100
code423n4
opened
2 years ago
2
Deadline based on `block.timestamp` is ineffective for in contract calls, removing them can make the code simpler and save gas
#99
code423n4
closed
2 years ago
1
`UniV3Vault.sol#collectEarnings()` can be front run
#98
code423n4
opened
2 years ago
1
`AaveVault` is vulnerable to flashloan sandwich attack
#97
code423n4
closed
2 years ago
2
Cache storage variables in the stack can save gas
#96
code423n4
opened
2 years ago
0
Remove unnecessary function can make the code simpler and save some gas
#95
code423n4
opened
2 years ago
0
`++i` is more efficient than `i++`
#94
code423n4
closed
2 years ago
1
Remove unnecessary variables can make the code simpler and save some gas
#93
code423n4
opened
2 years ago
0
Use immutable variables can save gas
#92
code423n4
opened
2 years ago
0
Wrong implementation of `performanceFee` can cause users to lose 50% to 100% of their funds
#91
code423n4
opened
2 years ago
0
`LpIssuer.sol#_chargeFees()` Check `if (performanceFee > 0)` can be done earlier to save gas
#90
code423n4
opened
2 years ago
0
Cache external call results can save gas
#89
code423n4
opened
2 years ago
3
Unsafe token transfer
#88
code423n4
opened
2 years ago
1
Cache array length in for loops can save gas
#87
code423n4
closed
2 years ago
1
Setting `uint256` variables to `0` is redundant
#86
code423n4
opened
2 years ago
0
Unchecked return value for `ERC20.approve` call
#85
code423n4
closed
2 years ago
1
Next