search

code-423n4 / 2021-12-nftx-findings

0 stars 0 forks source link

NFTXSimpleFeeDistributor: Changes are not compatible with existing FeeDistributor #219

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

GreyArt

Vulnerability details

Impact

Due to significant changes in the storage layout from FeeDistributor to the SimpleFeeDistributor, a new proxy should be deployed together with the implementation. There would otherwise be undesired storage collisions. For instance, allocTotal will take on the value of threshold = 10**9 when it is expected to be zero.

We’ve clarified that this is indeed the case (new proxy has been deployed). Nevertheless, we wanted to make sure that this incompatibility is made known.

0xKiwi commented 2 years ago

This is intentional. It is named differently since it is no longer compatible.

dmvt commented 2 years ago

Invalid