search

code-423n4 / 2021-12-pooltogether-findings

0 stars 0 forks source link

Gas Optimization: Redundant > 0 check #113

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

gzeon

Vulnerability details

Impact

https://github.com/pooltogether/v4-periphery/blob/b520faea26bcf60371012f6cb246aa149abd3c7d/contracts/TwabRewards.sol#L255

        require(
            _promotionEndTimestamp > 0 && _promotionEndTimestamp >= block.timestamp,
            "TwabRewards/promotion-not-active"
        );

block.timestamp always > 0 if _promotionEndTimestamp >= block.timestamp we also have _promotionEndTimestamp > 0

PierrickGT commented 2 years ago

Duplicate of https://github.com/code-423n4/2021-12-pooltogether-findings/issues/19