code-423n4 / 2021-12-pooltogether-findings

0 stars 0 forks source link

>0 -> !=0 #145

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

'> 0' can be replaced with '!= 0' which is a bit cheaper:

  if (data.length > 0)
  require(_promotionEndTimestamp > 0
  if (_averageTotalSupplies[0] > 0)
PierrickGT commented 2 years ago

Duplicate of https://github.com/code-423n4/2021-12-pooltogether-findings/issues/33