code-423n4 / 2021-12-pooltogether-findings

0 stars 0 forks source link

_promotionEndTimestamp > 0 #146

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

Under normal circumstances, block.timestamp is always > 0, so the first condition is not really necessary:

  require(
    _promotionEndTimestamp > 0 && _promotionEndTimestamp >= block.timestamp,
    "TwabRewards/promotion-not-active"
  );
PierrickGT commented 2 years ago

Duplicate of https://github.com/code-423n4/2021-12-pooltogether-findings/issues/19