issues
search
code-423n4
/
2021-12-pooltogether-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Tokens with fee on transfer are not supported
#99
code423n4
closed
2 years ago
1
`++i` is more efficient than `i++`
#98
code423n4
closed
2 years ago
1
Use short reason strings can save gas
#97
code423n4
closed
2 years ago
1
`cancelPromotion()` Validate input earlier can save gas
#96
code423n4
closed
2 years ago
1
`createPromotion()` Check if `_tokensPerEpoch * _numberOfEpochs > 0` before transfer can save gas
#95
code423n4
closed
2 years ago
1
`createPromotion()` Consider adding `require(_tokensPerEpoch > 0)`
#94
code423n4
closed
2 years ago
1
Attacker can empty all the funds by creating fake promotions
#93
code423n4
closed
2 years ago
1
Avoid unnecessary dynamic size array `_averageTotalSupplies` can save gas
#92
code423n4
closed
2 years ago
1
Avoid unnecessary dynamic size array `_averageTotalSupplies` can save gas
#91
code423n4
opened
2 years ago
0
`_requireTicket()` Implementation can be simpler and save some gas
#90
code423n4
opened
2 years ago
0
> 0 can be replaced with != 0 for gas optimisation
#89
code423n4
closed
2 years ago
1
Long Revert Strings
#88
code423n4
closed
2 years ago
1
_isClaimedEpoch must return wrong result
#87
code423n4
closed
2 years ago
1
A more efficient for loop index proceeding
#86
code423n4
closed
2 years ago
1
_updateClaimedEpoch might behave unexpectedly
#85
code423n4
closed
2 years ago
1
TwabRewards: fee on transfer token as promotion token can make claimRewards() fail
#84
code423n4
closed
2 years ago
1
_calculateRewardAmount might return wrong result
#83
code423n4
closed
2 years ago
1
Possibility to drain TwabRewards smart contract tokens (even with valid ticket)
#82
code423n4
closed
2 years ago
1
unsafe cast can lead to theft
#81
code423n4
closed
2 years ago
1
`getRewardsAmount` might return wrong result
#80
code423n4
opened
2 years ago
1
unnecessary check in require
#79
code423n4
closed
2 years ago
1
Can drain any promotion rewards with a evil ticket
#78
code423n4
closed
2 years ago
1
TwarbRewards: don't use the onlyPromotionCreator modifier to save gas
#77
code423n4
opened
2 years ago
0
Unnecessary check for _promotionEndTimestamp
#76
code423n4
closed
2 years ago
1
Dust Token Balances Cannot Be Claimed By An `admin` Account
#75
code423n4
opened
2 years ago
0
Can claim epoch > 255 repeatedly due to bitshift truncation
#74
code423n4
closed
2 years ago
1
Can drain any promotion rewards
#73
code423n4
closed
2 years ago
1
`claimRewards` Does Not Prevent Users From Claiming Rewards After A Promotion's End Epoch
#72
code423n4
closed
2 years ago
1
Possibility to drain TwabRewards smart contract tokens
#71
code423n4
closed
2 years ago
1
Missing Check When Transferring Tokens Out For A Given Promotion
#70
code423n4
opened
2 years ago
1
Gas: Redundant check in `_requirePromotionActive`
#69
code423n4
closed
2 years ago
1
Anyone can claim rewards on behalf of someone
#68
code423n4
opened
2 years ago
1
Allowing more than 256 epochs leads to loss of funds
#67
code423n4
closed
2 years ago
1
Can delegate burnt tokens to oneself
#66
code423n4
closed
2 years ago
2
Wrong comment regarding _claimedEpochs
#65
code423n4
closed
2 years ago
1
Gas Optimization: `epochIds.length` Can Be Declared Outside Of `for` Loop
#64
code423n4
closed
2 years ago
1
Gas Optimization: Remove Redundant Checks In `for` Loop
#63
code423n4
closed
2 years ago
2
Gas Optimization: Efficient Struct Packing
#62
code423n4
closed
2 years ago
1
Malicious Promotion Creators Can Drain Token Balances
#61
code423n4
closed
2 years ago
1
User can withdraw more rewards than expected by moving their tickets to a different wallet within an epoch
#60
code423n4
closed
2 years ago
2
Missing Validation Of `createPromotion` Parameters
#59
code423n4
closed
2 years ago
1
uint256 types can be uint64
#58
code423n4
opened
2 years ago
0
Redundant _promotionEndTimestamp check
#57
code423n4
closed
2 years ago
1
Revert string > 32 bytes
#56
code423n4
closed
2 years ago
1
StartTimestamp is not checked
#55
code423n4
closed
2 years ago
1
Inconsistent definition of when an epoch ends
#54
code423n4
opened
2 years ago
0
_getPromotion does not revert if promotion does not exist
#53
code423n4
closed
2 years ago
2
claimRewards _epochIds should be uint8[] instead of uint256[]
#52
code423n4
closed
2 years ago
1
Users can claim rewards on epochIds that don't exist
#51
code423n4
closed
2 years ago
1
getRewardsAmount doesn't check epochs haven't been claimed
#50
code423n4
opened
2 years ago
0
Previous
Next