issues
search
code-423n4
/
2021-12-sublime-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Zyc
#172
code423n4
closed
2 years ago
2
Users Can Siphon `AaveYield` Rewards By Depositing And Withdrawing Collateral
#171
code423n4
closed
2 years ago
1
Event missing when removing a vote in extensions
#170
code423n4
opened
2 years ago
2
Collateral can be deposited in a finished pool
#169
code423n4
opened
2 years ago
2
Ether can be locked in the `PoolFactory` contract without a way to retrieve it
#168
code423n4
opened
2 years ago
2
some events are not indexed
#167
code423n4
closed
2 years ago
2
missing nonreentrant modfier
#166
code423n4
opened
2 years ago
2
Change state mutability in NoYield.sol
#165
code423n4
opened
2 years ago
0
Unused variables in SavingsAccount.sol
#164
code423n4
closed
2 years ago
1
missing nonreentrant modifier
#163
code423n4
closed
2 years ago
2
Failed transfer with low level call could be overlooked
#162
code423n4
closed
2 years ago
1
Use Solidity 0.8
#161
code423n4
closed
2 years ago
1
Not needed zero address check
#160
code423n4
opened
2 years ago
0
Use preincrement for `id` to save gas
#159
code423n4
closed
2 years ago
1
Don't assign default values
#158
code423n4
closed
2 years ago
1
Loops can be implemented more efficiently
#157
code423n4
opened
2 years ago
0
In `CreditLine#liquidate`, lender doesn't receive `_borrowTokens`, when it is ETH
#156
code423n4
closed
2 years ago
1
In `CreditLine#_borrowTokensToLiquidate`, oracle is used wrong way
#155
code423n4
opened
2 years ago
0
denial of service
#154
code423n4
opened
2 years ago
0
Missing payable
#153
code423n4
closed
2 years ago
2
Unnecessary payable
#152
code423n4
closed
2 years ago
1
Two Steps Verification before Transferring Ownership
#151
code423n4
closed
2 years ago
1
Missing Slippage Protection
#150
code423n4
closed
2 years ago
2
Borrowers are unable to repay a defaulted loan
#149
code423n4
closed
2 years ago
2
Gas: Use `else if` in `withdrawLiquidity`
#148
code423n4
opened
2 years ago
0
Gas: Unnecessary assignment in `SavingsAccount.withdrawAll`
#147
code423n4
closed
2 years ago
1
Self-transfer leads to wrong withdrawable repayments
#146
code423n4
opened
2 years ago
0
DoS when depositing collateral
#145
code423n4
closed
2 years ago
2
Borrow should increase principal by withdrawn amount
#144
code423n4
closed
2 years ago
1
Collateral deposit does not support fee-on-transfer tokens
#143
code423n4
opened
2 years ago
2
`NoYield.sol` Tokens with fee on transfer are not supported
#142
code423n4
opened
2 years ago
0
Extension voting threshold check needs to rerun on each transfer
#141
code423n4
opened
2 years ago
0
Extension voting power can be flashloaned
#140
code423n4
opened
2 years ago
2
Restrict fee percentages to 100%
#139
code423n4
closed
2 years ago
1
Pool direct savingsaccount deposits fail when no strategy set
#138
code423n4
opened
2 years ago
2
Aave's share tokens are rebasing breaking current strategy code
#137
code423n4
opened
2 years ago
2
approve return values not checked
#136
code423n4
opened
2 years ago
1
`unlockShares` wrong comment
#135
code423n4
opened
2 years ago
0
Yearn token <> shares conversion decimal issue
#134
code423n4
opened
2 years ago
0
`initialize` functions can be frontrun
#133
code423n4
closed
2 years ago
1
Wrong returns of `SavingsAccountUtil.depositFromSavingsAccount()` can cause fund loss
#132
code423n4
opened
2 years ago
0
Lack of input validation
#131
code423n4
closed
2 years ago
2
`SavingsAccount.sol` Wrong `amount` in `Transfer` events
#130
code423n4
opened
2 years ago
2
Gas Optimization: Struct layout
#129
code423n4
opened
2 years ago
0
`AaveYield.getTokensForShares()`, `AaveYield.getSharesForTokens()` Implementation can be simpler and save some gas
#128
code423n4
opened
2 years ago
1
`Pool.sol#withdrawBorrowedAmount()` Validation of pool status can be done earlier to save gas
#127
code423n4
opened
2 years ago
0
`10**30` can be changed to `1e30` and save some gas
#126
code423n4
opened
2 years ago
0
Only using SafeMath when necessary can save gas
#125
code423n4
closed
2 years ago
1
Inline unnecessary function can make the code simpler and save some gas
#124
code423n4
opened
2 years ago
1
Wrong implementation of `AaveYield.sol` causing users to lose yields
#123
code423n4
closed
2 years ago
1
Next