search

code-423n4 / 2021-12-vader-findings

0 stars 0 forks source link

Open TODOs #116

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

defsec

Vulnerability details

Impact

Open TODOs can point to architecture or programming issues that still need to be resolved. Timestamp in the Vaderpool should be re-evaluated.

Proof of Concept

  1. Navigate to the following contracts.
https://github.com/code-423n4/2021-12-vader/blob/main/contracts/dex-v2/pool/VaderPoolV2.sol#L184

https://github.com/code-423n4/2021-12-vader/blob/main/contracts/dex-v2/pool/VaderPoolV2.sol#L237

https://github.com/code-423n4/2021-12-vader/blob/main/contracts/dex-v2/pool/VaderPoolV2.sol#L293

Tools Used

None

Recommended Mitigation Steps

Consider resolving the TODOs before deploying.

jack-the-pug commented 2 years ago

Dup of #183