code-423n4 / 2021-12-vader-findings

0 stars 0 forks source link

denial of service #135

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

danb

Vulnerability details

https://github.com/code-423n4/2021-12-vader/blob/main/contracts/lbt/LiquidityBasedTWAP.sol#L93 chainlink price might be negative, it's not a malfunction: https://stackoverflow.com/questions/67094903/anybody-knows-why-chainlinks-pricefeed-return-price-value-with-int-type-while if one of the tokens has anegative price, the system will be in denial of service.

SamSteinGG commented 2 years ago

Chainlink price can not be negative

jack-the-pug commented 2 years ago

Dup #111