code-423n4 / 2021-12-yetifinance-findings

0 stars 0 forks source link

Gas saving in ShortLockupContract #133

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

0x1f8b

Vulnerability details

Impact

Gas saving.

Proof of Concept

The variables yetiToken and unlockTime inside the ShortLockupContract contract are never modified, so it's better to use immutable to avoid storage access.

Tools Used

Gas saving

Recommended Mitigation Steps

Use immutable

kingyetifinance commented 2 years ago

@LilYeti: #132 is very similar, these could have been reported together as they were from same warden.