code-423n4 / 2021-12-yetifinance-findings

0 stars 0 forks source link

Require without a message #154

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

certora

Vulnerability details

Impact

You have multiple requires without a message. This could be confusing for users, their transaction will fail and they won't know why. For example ActivePool lines 157, 166, 183 BorrowerOperations lines 434,435 and more..

Tools Used

Manual code review

Recommended Mitigation Steps

Add a message in the require to help users

kingyetifinance commented 2 years ago

@LilYeti: Should be severity 0: for user interactions off chain.

kingyetifinance commented 2 years ago

Duplicate with #17

alcueca commented 2 years ago

Duplicate #265

alcueca commented 2 years ago

Issues with error messages are at most non-critical.